[PATCH] D133030: [AIX] llvm-readobj support a new option --exception-section for xcoff object file.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 16 00:18:39 PDT 2022


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

One remaining nit, otherwise LGTM.



================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:455
+    SmallString<32> UnknownType;
+    Twine(("<Unknown:") + Twine::utohexstr(SectType) +">").toVector(UnknownType);
+    const char *SectionName = UnknownType.c_str();
----------------
Do you need to add the `0x` explicitly? I haven't looked at `uthexstr`, so it might not need it, but I think we should have the 0x to make it clear it is in hex.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133030/new/

https://reviews.llvm.org/D133030



More information about the llvm-commits mailing list