[PATCH] D133992: [objdump] Add --build-id flag for debuginfod lookups without binary.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

New options need adding to the CommandGuide documentation. Please update the relevant llvm/CommandGuide file.



================
Comment at: llvm/tools/llvm-objdump/ObjdumpOpts.td:42
+defm build_id :
+  Eq<"build-id", "Build ID to look up. Once found, added as an input file.">,
+  MetaVarName<"<dir>">;
----------------
Other options don't have a trailing full stop for their description in this file.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2797-2798
+  if (!tryGetFromHex(V, Bytes))
+    reportCmdLineError(A->getSpelling() + ": expected a build ID, but got '" +
+                       V + "'");
+  ArrayRef<uint8_t> BuildID(reinterpret_cast<const uint8_t *>(Bytes.data()),
----------------
Test case for this error?


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2975-2976
+    if (!Path) {
+      reportCmdLineError(A->getSpelling() + ": could not find build ID '" +
+                         A->getValue() + "'");
+    }
----------------
Test case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133992/new/

https://reviews.llvm.org/D133992