[PATCH] D127628: [NewGVN][LoadCoercion][3/3] Replace load with a phi node

[Konstantina Mitropoulou via Phabricator via llvm-commits]

kmitropoulou added inline comments.


================
Comment at: llvm/test/Transforms/NewGVN/basic-cyclic-opt.ll:259
 ; CHECK:       bb3:
-; CHECK-NEXT:    ret i8 0
+; CHECK-NEXT:    [[TMP3:%.*]] = add i8 0, 0
+; CHECK-NEXT:    ret i8 [[TMP3]]
----------------
kmitropoulou wrote:
> I need to check why NewGVN does not eliminate the add.
If load coercion is successful, we remove the load and we update its uses with the coerced value. In this case, the updated instructions can be eliminated further. For this reason, we run value numbering for the uses of the load that was optimized.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127628/new/

https://reviews.llvm.org/D127628