[PATCH] D132495: [BOLT] Verify externally referenced blocks against jump table targets

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb accepted this revision.
maksfb added a comment.
This revision is now accepted and ready to land.

LGTM, but please rename the method before the commit.



================
Comment at: bolt/lib/Core/BinaryFunction.cpp:1908-1909
+  // points.
+  if (!opts::StrictMode && hasInternalReference()) {
+    if (!validateExternalReferences())
+      return false;
----------------
There's an apparent confusion with "internal" vs "external" reference in this context. Let's rename the method to `validateExternallyReferencedOffsets()` or `validateReferencedOffsets()` to avoid it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132495/new/

https://reviews.llvm.org/D132495