[PATCH] D128998: [libunwind] Handle G in personality string

[Florian Mayer via Phabricator via llvm-commits]

fmayer added inline comments.


================
Comment at: libunwind/src/libunwind.cpp:186
+// particular, this resets MTE tags of tagged frames to zero.
+_LIBUNWIND_HIDDEN int __unw_clean_step(unw_cursor_t *cursor) {
+  _LIBUNWIND_TRACE_API("__unw_clean_step(cursor=%p)",
----------------
compnerd wrote:
> I think that `untag` is better than clean - `__unw_step_untag`.  We are untagging the memory and that makes it more clear.
OK. I wanted to keep this name generic in case we need to do other cleanup steps later, but we can also cross that bridge when/if we get there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128998/new/

https://reviews.llvm.org/D128998