[PATCH] D133969: [IPO] Simplify the module inliner loop (NFC)

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 13:00:10 PDT 2022


kazu created this revision.
Herald added subscribers: ormris, hiraditya.
Herald added a project: All.
kazu requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

In the bottom-up inliner, we have a two-level nested "while" loop,
with the inner one grouping call sites with the same caller.  We need
to do so to keep CGSCC up to date.

Now, with the module inliner, we don't have any per-caller work.  We
don't update CGSCC.  Plus, the caller will likely keep changing as we
pop call sites in some priority order.

This patch simply removes the inner "while" loop while indenting its
body.  Further cleanup is possible, but that's left for follow-up
patches.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133969

Files:
  llvm/lib/Transforms/IPO/ModuleInliner.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133969.460486.patch
Type: text/x-patch
Size: 7938 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220915/8a04f4f3/attachment.bin>


More information about the llvm-commits mailing list