[PATCH] D133825: [lld-macho] Add support for N_INDR symbols

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 11:27:52 PDT 2022


int3 added a comment.

Sorry, I do run tests locally, just not always with assertions enabled...

I'm not sure I understand the purpose of the assertion tbh -- @thakis you introduced it in D102076 <https://reviews.llvm.org/D102076>. We're triggering it now because alias symbols can be weak + can be defined with a different `InputFile` than the section they ultimately belong to. Can we just remove the assert?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133825/new/

https://reviews.llvm.org/D133825



More information about the llvm-commits mailing list