[PATCH] D133902: X86: Stop assigning register costs for longer encodings

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In D133902#3791069 <https://reviews.llvm.org/D133902#3791069>, @craig.topper wrote:

> Looks like the code change to X86RegisterInfo.td is not in this patch?

huh. It's included now.

> D86836 <https://reviews.llvm.org/D86836> introduced support for setting multiple CostPerUse values (which we use on RISC-V to set a non-zero value for some registers only when the 'compressed' extension is enabled). Did you evaluate doing something similar to only set CostPerUse at Os or perhaps Oz?

Yes I saw that, didn't push on this angle (yet) as we should really use `llvm::shouldOptimizeForSize` then which requires a `ProfileSummaryInfo` reference that isn't around in that callback. So would need to refactor those interfaces in some way...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133902/new/

https://reviews.llvm.org/D133902