[PATCH] D133860: StackProtector: enable tail call optimization even without musttail

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 10:33:03 PDT 2022


compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/StackProtector.cpp:478
     // return or with a single correct bitcast of the return value in between so
     // we don't need to worry about many situations here.
     Instruction *CheckLoc = RI;
----------------
Please update the comment to replace the references to `musttail`.


================
Comment at: llvm/test/CodeGen/AArch64/stack-protector-musttail.ll:106
+}
\ No newline at end of file

----------------
Add missing newline please.


================
Comment at: llvm/test/CodeGen/ARM/Windows/stack-protector-musttail.ll:88
+}
\ No newline at end of file

----------------
Add missing newline please


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133860/new/

https://reviews.llvm.org/D133860



More information about the llvm-commits mailing list