[PATCH] D112942: target ABI: improve call parameters extensions handling

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 08:48:42 PDT 2022


jonpa added a comment.

In D112942#3787224 <https://reviews.llvm.org/D112942#3787224>, @efriedma wrote:

> "signext" doesn't really make sense on llvm.memset: it's not a call.  It's an intrinsic.  It might be lowered to a call, but that's not really relevant: even if we do generate a call, there's no reason to expect that call's calling convention is the same as memset's calling convention.  instcombine transferring it is just an accident.
>
> The ASan instrumentation pass should be able to figure out the correct attributes for any functions it calls from first principles (possibly using TargetLibraryInfo::getExtAttrForI32Param(), like other instrumentation passes).

ok - started working on that here: https://reviews.llvm.org/D133949


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112942/new/

https://reviews.llvm.org/D112942



More information about the llvm-commits mailing list