[PATCH] D133310: [Assignment Tracking][15/*] Account for assignment tracking in simplifycfg

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

Thanks for taking a look



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1899
+    // In most (all?) cases this just introduces a use-before-def.
+    assert(I->user_empty() && "I unexpectedly still has non-dbg users");
+    I->replaceAllUsesWith(I0);
----------------
chrisjackson wrote:
> 
I was referring to the variable `I` there, but `Instruction` makes more sense and is not ambiguous. I'll update when I come to land this (or if major updates are required) if that's ok?


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:2576
   // be misleading while debugging.
   // Similarly strip attributes that maybe dependent on condition we are
   // hoisting above.
----------------
chrisjackson wrote:
> 
I didn't add the comment above, but happy to fold in the update if you want.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133310/new/

https://reviews.llvm.org/D133310