[PATCH] D133731: [AMDGPU] Add Lower Bound to PipelineSolver

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:68
+             "for a partial fit using the exact solver. The lower bound "
+             "calcalutes the cost of assigning the remaining instructions "
+             "under idealized conditions. The LB reduces the overall search "
----------------
Typo calcalutes


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:566
+  int MinimumCost = 0;
+  std::vector<std::pair<SUnit *, SUnit *>> AddedEdges;
+
----------------
I'd assume this can be a SmallVector


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133731/new/

https://reviews.llvm.org/D133731