[PATCH] D133307: [Assignment Tracking][14/*] Account for assignment tracking in instcombine

[Chris Jackson via Phabricator via llvm-commits]

chrisjackson added a comment.

A typo and a couple of nitish suggestions.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:273
     // Extract the fill value and store.
     uint64_t Fill = FillC->getZExtValue()*0x0101010101010101ULL;
+    auto *FillVal = ConstantInt::get(ITy, Fill);
----------------



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:274
     uint64_t Fill = FillC->getZExtValue()*0x0101010101010101ULL;
-    StoreInst *S = Builder.CreateStore(ConstantInt::get(ITy, Fill), Dest,
-                                       MI->isVolatile());
+    auto *FillVal = ConstantInt::get(ITy, Fill);
+    StoreInst *S = Builder.CreateStore(FillVal, Dest, MI->isVolatile());
----------------



================
Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/instcombine/memset.ll:15
+
+;; Instcombine is going to turn th second memset into a store. Check that it
+;; inherits the DIAssignID from the memset and that the dbg.assign's value
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133307/new/

https://reviews.llvm.org/D133307