[PATCH] D133310: [Assignment Tracking][15/*] Account for assignment tracking in simplifycfg

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 05:49:06 PDT 2022


Orlando added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1897-1898
+      continue;
+    // The remaining uses are debug users, replace those with the common inst.
+    // In most (all?) cases this just introduces a use-before-def.
+    I->replaceAllUsesWith(I0);
----------------
jmorse wrote:
> This can (should!) be asserted; also, techncially can be peeled away from dbg.assign improvements if this also affects dbg.values?
I spent some time trying to find an interesting source reproducer without assignment tracking but failed to found one. If you're happy with an artificial (/hand-written) test then I could move this into its own patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133310/new/

https://reviews.llvm.org/D133310



More information about the llvm-commits mailing list