[PATCH] D133846: [libunwind] Fix usage of `_dl_find_object` on 32-bit x86

Adrian Vogelsgesang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 05:26:35 PDT 2022


avogelsgesang updated this revision to Diff 460375.
avogelsgesang added a comment.

remove `assert` completely


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133846/new/

https://reviews.llvm.org/D133846

Files:
  libunwind/src/AddressSpace.hpp


Index: libunwind/src/AddressSpace.hpp
===================================================================
--- libunwind/src/AddressSpace.hpp
+++ libunwind/src/AddressSpace.hpp
@@ -584,11 +584,6 @@
   // support for _dl_find_object on other unwind formats is not implemented,
   // yet.
 #if defined(DLFO_STRUCT_HAS_EH_DBASE) & defined(_LIBUNWIND_SUPPORT_DWARF_INDEX)
-  // We expect to run on a platform which does not use a base address for
-  // exception information.
-#if DLFO_STRUCT_HAS_EH_DBASE
-#error dlfo_eh_dbase is not supported for DWARF-based unwinding
-#endif
   // We expect `_dl_find_object` to return PT_GNU_EH_FRAME.
 #if DLFO_EH_SEGMENT_TYPE != PT_GNU_EH_FRAME
 #error _dl_find_object retrieves an unexpected section type


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133846.460375.patch
Type: text/x-patch
Size: 741 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220915/ed5b88d1/attachment.bin>


More information about the llvm-commits mailing list