[PATCH] D133923: [Release] Add bump-version script.

Konrad Wilhelm Kleine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 15 02:04:33 PDT 2022


kwk added a comment.

In D133923#3791676 <https://reviews.llvm.org/D133923#3791676>, @thieta wrote:

> In D133923#3791675 <https://reviews.llvm.org/D133923#3791675>, @tschuett wrote:
>
>> There is no room for a `VERSION` file at the root of the repository and everybody reads the file if necessary?
>
> I suggested this at some point - but it never got traction. Maybe showing the complexity of this script can be a catalyst of changing this (especially for the bazel build system).
>
> I have used this script for 15.x branch just to make sure I don't forget anything, since it's many files that needs to be updated.

So far I've consumed only the `llvm/CMakeLists.txt` to get the version but that's of course hard-coded into the llvm subproject. I didn't know that there were so many places. I highly suggest to create a discourse post and point to this script. IMHO there's no point in doing this in so many places but rather have everything in one place and let the subprojects consume from it. In order to gain acceptance of such a mundane task, I suggest to create another patch that shows how to consume this version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133923/new/

https://reviews.llvm.org/D133923



More information about the llvm-commits mailing list