[PATCH] D133914: [InlineAsm][bugfix] Correct function addressing in inline asm

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/test/CodeGen/X86/inline-asm-p-constraint.ll:14
+; CHECK-NEXT: lea -8(%rsp), %rax
 ; CHECK-NEXT: #NO_APP
   ret ptr %1
----------------
@jonpa I think here you may mis-understand lea, so I updated here.
And I think the mov (%rdi) should be mov %rdi in constrain of "p" you add before.

At first I updated the 'p' action to "direct action" (without load: mov %rdi), but it affect systemZ tests which I am not familiar with. So I want to discuss with you about the action of "p" here.

"p" should be address which equal with "direct mem (without load)".
 So in DAG build (pls refer the change in SelectionDAGBuilder.cpp) the OpInfo.isIndirect should always be false;


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133914/new/

https://reviews.llvm.org/D133914