[PATCH] D133545: [PowerPC][NFC] Add test case to show CSR_64_AllRegs_AIX_Dflt_VSX is not correct

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 21:40:48 PDT 2022


amyk added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix64-patchpoint-regmask.ll:1
+; RUN: llc -O0 -verify-machineinstrs -mcpu=pwr9 -mtriple powerpc64-ibm-aix-xcoff -print-after=finalize-isel --print-regmask-num-regs=-1 < %s 2>&1 | \
+; RUN: FileCheck %s
----------------
Nit: I think this line maybe too long. Perhaps we can try separating this run line further.


================
Comment at: llvm/test/CodeGen/PowerPC/aix64-patchpoint-regmask.ll:4
+
+; Error regmask pattern should be fixed: v20:v31 should be reserved in AIX defalut ABI
+; CHECK: PATCHPOINT{{[^<]+}}<regmask {{[^>]+}} $v20 $v21 $v22 $v23 $v24 $v25 $v26 $v27 $v28 $v29 $v30 $v31 {{[^>]+}}>
----------------
Minor spelling typo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133545/new/

https://reviews.llvm.org/D133545



More information about the llvm-commits mailing list