[PATCH] D133678: [msan] Check mask and pointers shadow

[Kevin Athey via Phabricator via llvm-commits]

kda added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3276-3277
+    Value *Ptrs = I.getArgOperand(0);
+    const Align Alignment(
+        cast<ConstantInt>(I.getArgOperand(1))->getZExtValue());
+    Value *Mask = I.getArgOperand(2);
----------------
kda wrote:
> What is this for?
> It does not seem to be used.
Maybe move to https://reviews.llvm.org/D133682, as you did for handleMaskedScatter.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3298
+    Value *Ptrs = I.getArgOperand(1);
+    Value *Mask = I.getArgOperand(3);
+
----------------
kda wrote:
> not 2?
I see you using it in https://reviews.llvm.org/D133682.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133678/new/

https://reviews.llvm.org/D133678