[PATCH] D133905: [RISCV] Simplify some code in RISCVInstrInfo::verifyInstruction. NFCI
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 14 17:07:41 PDT 2022
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5888c157a74b: [RISCV] Simplify some code in RISCVInstrInfo::verifyInstruction. NFCI (authored by craig.topper).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133905/new/
https://reviews.llvm.org/D133905
Files:
llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
Index: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
===================================================================
--- llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
+++ llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
@@ -1127,8 +1127,7 @@
bool RISCVInstrInfo::verifyInstruction(const MachineInstr &MI,
StringRef &ErrInfo) const {
- const MCInstrInfo *MCII = STI.getInstrInfo();
- MCInstrDesc const &Desc = MCII->get(MI.getOpcode());
+ MCInstrDesc const &Desc = MI.getDesc();
for (auto &OI : enumerate(Desc.operands())) {
unsigned OpType = OI.value().OperandType;
@@ -1195,17 +1194,14 @@
Ok = isShiftedInt<7, 5>(Imm);
break;
case RISCVOp::OPERAND_UIMMLOG2XLEN:
- Ok = STI.getTargetTriple().isArch64Bit() ? isUInt<6>(Imm)
- : isUInt<5>(Imm);
+ Ok = STI.is64Bit() ? isUInt<6>(Imm) : isUInt<5>(Imm);
break;
case RISCVOp::OPERAND_UIMMLOG2XLEN_NONZERO:
- Ok = STI.getTargetTriple().isArch64Bit() ? isUInt<6>(Imm)
- : isUInt<5>(Imm);
+ Ok = STI.is64Bit() ? isUInt<6>(Imm) : isUInt<5>(Imm);
Ok = Ok && Imm != 0;
break;
case RISCVOp::OPERAND_UIMM_SHFL:
- Ok = STI.getTargetTriple().isArch64Bit() ? isUInt<5>(Imm)
- : isUInt<4>(Imm);
+ Ok = STI.is64Bit() ? isUInt<5>(Imm) : isUInt<4>(Imm);
break;
case RISCVOp::OPERAND_RVKRNUM:
Ok = Imm >= 0 && Imm <= 10;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133905.460267.patch
Type: text/x-patch
Size: 1608 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220915/696f1b7d/attachment.bin>
More information about the llvm-commits
mailing list