[PATCH] D131576: [AArch64][SME] Implement ABI for calls to/from streaming functions.
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 14 14:10:31 PDT 2022
aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:4513
+ if (auto *ES = dyn_cast<ExternalSymbolSDNode>(V))
+ return StringSwitch<bool>(ES->getSymbol())
+ .Case("__arm_sme_state", true)
----------------
sdesmalen wrote:
> aemerson wrote:
> > Why not just use StringRef to compare?
> This was more to write it in an extensible way such that other cases can be added later. I've rewritten this a bit now to support ZA as well.
Ah ok, feel free to change it back then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131576/new/
https://reviews.llvm.org/D131576
More information about the llvm-commits
mailing list