[PATCH] D133881: [AMDGPU][MC][GFX11] Add validation of constant bus limitations for VOPD

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 13:57:19 PDT 2022


rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:3503
+  for (int OpIdx : OpIndices) {
+    if (OpIdx == -1) continue;
+
----------------
Could you please move 'continue' onto a separate line?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133881/new/

https://reviews.llvm.org/D133881



More information about the llvm-commits mailing list