[PATCH] D133880: [msan] Change logic of ClInstrumentationWithCallThreshold

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

In D133880#3790453 <https://reviews.llvm.org/D133880#3790453>, @kstoimenov wrote:

> This seems to have changed the logic for emitting callbacks to such that it would emit inlined code and once the threshold is reached it would start outlining them. Before it would either always emit outlined or always inlined for each function. Is that correct and if so it is intended?

Yes. This is just workaround for huge number of basic blocks. So I don't think this particular part is important.
Alternative is to first pass handle constants, then InstrumentWithCalls, and run another pass as before, using InstrumentWithCalls.
However it looks like causing more convoluted code without a reason.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133880/new/

https://reviews.llvm.org/D133880