[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

Stella Laurenzo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 13:01:29 PDT 2022


stellaraccident added a comment.

In D133823#3789844 <https://reviews.llvm.org/D133823#3789844>, @rriddle wrote:

> I imagine APFloat changes likely require an RFC (though I'm not sure). Also, did you accidentally reformat all of the APFloat tests (4k lines change o.O)

Sorry: noted this patch in the RFC but didn't put the reverse link here: https://discourse.llvm.org/t/rfc-add-apfloat-and-mlir-type-support-for-fp8-e5m2/65279

Ugh, yeah, APFloatTest was very not formatted and clang-format "helped". I tried to stack an NFC clang-format under this one but seem to have messed something up. Could you offer any advice on what to do (I was thinking of just pre-landing an NFC clang-format of APFloatTest and then rebasing on top of that).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133823/new/

https://reviews.llvm.org/D133823



More information about the llvm-commits mailing list