[PATCH] D133880: [msan] Change logic of ClInstrumentationWithCallThreshold

[Kirill Stoimenov via Phabricator via llvm-commits]

kstoimenov added a comment.

This seems to have changed the logic for emitting callbacks to such that it would emit inlined code and once the threshold is reached it would start outlining them. Before it would either always emit outlined or always inlined for each function. Is that correct and if so it is intended?



================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1155
+  bool InstrumentWithCall(Value *V) {
+    // Constants likely will be eliminated by folloup passes.
+    if (!isa<Constant>(V))
----------------
s/folloup/follow-up/


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1156
+    // Constants likely will be eliminated by folloup passes.
+    if (!isa<Constant>(V))
+      --SplitBlockBudget;
----------------
To avoid negative integer underflow. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133880/new/

https://reviews.llvm.org/D133880