[PATCH] D132657: [DSE] Eliminate noop store even through has clobbering between LoadI and StoreI

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 12:44:04 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1875
+                            ->getDataLayout()
+                            .getABITypeAlign(LoadI->getType()))
+                  continue;
----------------
`getABITypeAlign(LoadI->getType()))` doesn't make sense.  It doesn't matter what the ABI alignment of the type is; the question here is whether the alignment of the load is greater than or equal to the size of the load.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132657/new/

https://reviews.llvm.org/D132657



More information about the llvm-commits mailing list