[PATCH] D133825: [lld-macho] Add support for N_INDR symbols

[Vincent Lee via Phabricator via llvm-commits]

thevinster added inline comments.


================
Comment at: lld/MachO/SymbolTable.cpp:120
+                                   InputFile *newFile, bool makePrivateExtern) {
+  bool isPrivateExtern = makePrivateExtern || src->privateExtern;
+  return addDefined(target, newFile, src->isec, src->value, src->size,
----------------
int3 wrote:
> thevinster wrote:
> > Does this mean that both the alias and aliased symbol can differ in symbol visibility? If so, might be worth adding a test for it if it's expected behavior. 
> I'm not sure I understand the question. Are you asking if they can have visibilities that differ from each other? Yes, but that is already being tested...
Whoops, must've missed that. I guess it would be nice to also test a global alias to a private extern symbol too just to make sure we test all combinations. But I see, thakis@ already commented that as well. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133825/new/

https://reviews.llvm.org/D133825