[PATCH] D133537: [pipelines] RecomputeGlobalsAAPass after OptimizerEarlyEPCallbacks

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D133537#3788251 <https://reviews.llvm.org/D133537#3788251>, @vitalybuka wrote:

> In D133537#3788056 <https://reviews.llvm.org/D133537#3788056>, @aeubanks wrote:
>
>> In D133537#3787925 <https://reviews.llvm.org/D133537#3787925>, @vitalybuka wrote:
>>
>>> Wouldn't be better to do so on PassBuilderPipelines like this, so we can cover any other future abandoning hooks?
>>
>> We don't do that for all callbacks, I don't see why OptimizerEarlyEPCallbacks should be special. It's not typical to add passes that add globals. That's why it feels like it belongs wherever we add sanitizers.
>
> It's fine to me either way. However we don't do RecomputeGlobalsAAPass before other callback either.

The existing `RecomputeGlobalsAAPass` is specifically because we want the module optimization pipeline to have as refined AA as possible.
I'd still prefer adding this wherever we add sanitizers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133537/new/

https://reviews.llvm.org/D133537