[PATCH] D132443: [LSR] Fold terminating condition to other IV when possible

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 09:38:44 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6583
 
+static std::tuple<bool, PHINode *, PHINode *>
+canFoldTermCondOfLoop(Loop *L, ScalarEvolution &SE, DominatorTree &DT,
----------------
Looking at this again. Could this be an `Optional<std::pair<PHINode *, PHINode *>>` Then you could `return None` for CantFold.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132443/new/

https://reviews.llvm.org/D132443



More information about the llvm-commits mailing list