[PATCH] D133864: [AMDGPU][MC][GFX11] Add VOPD literals validation

[Joe Nash via Phabricator via llvm-commits]

Joe_Nash added inline comments.


================
Comment at: llvm/test/MC/AMDGPU/gfx11_asm_vopd_errs.s:37
+
+v_dual_fmamk_f32    v122, 0xdeadbeef, 0xdeadbeef, v161 ::  v_dual_fmamk_f32  v123, s0, 0xdeadbee, v162
+// GFX11: error: only one literal operand is allowed
----------------
I would prefer if there are multiple literals that they are quite visually distinct, rather than just omitting a trailing character or permuting one character


================
Comment at: llvm/test/MC/AMDGPU/gfx11_asm_vopd_errs.s:41
+// GFX11-NEXT:{{^}}                          ^
+
+//===----------------------------------------------------------------------===//
----------------
It may be worth checking for the 'odd one out' literal in each possible position. 4 tests


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133864/new/

https://reviews.llvm.org/D133864