[PATCH] D132755: [DWARFLinker][NFC] Set the target DWARF version explicitly.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

In D132755#3779145 <https://reviews.llvm.org/D132755#3779145>, @dblaikie wrote:

> Mixed feelings, but the indexing situation's somewhat motivational - though I think it'd be OK for it to be an error if you asked for DWARFv5 accelerator tables but the contents was producing DWARFv4 (or to have the request for DWARFv5 accelerator tables to up the version to DWARFv5 - though that wouldn't need a user-visible option to explicitly ask for DWARFv5)
>
> But don't mind me - was curious, but not a blocker.

This support exists because dsymutil has the ability to upgrade the accelerator tables. IIRC Greg added this when he designed the Apple accelerator tables. I extended that support when we added support for `.debug_names` and used that to test LLDB. So this is definitely intentional.

Things are easy when the user explicitly asked for a given accelerator type. I think the same thing makes sense for the DWARF version which is what this patch is doing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132755/new/

https://reviews.llvm.org/D132755