[PATCH] D133294: [Assignment Tracking][11/*] Update RemoveRedundantDbgInstrs

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM. Due diligence: is there a scenario you can think of where there would be meaningful difference in the generated debug-info if the tested-for dbg.assign in remove-redundant-fwd-scan-linked.ll were dropped? As mentioned it feels like a meaningful transition (linked -> unlinked), but I can't put my finger on exactly what it means.



================
Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/remove-redundant.ll:18
+;; Forward scan: dbg.assign for Local unlinked with undef value component, in
+;; the enrty bock and seen before any non-undefs; delete it.
+; CHECK-NEXT: @step()
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133294/new/

https://reviews.llvm.org/D133294