[PATCH] D132205: [llvm-tblgen] CodeGenSchedModels::hasReadOfWrite gets wrong predication result

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.

Patch looks good to me modulo a couple of minor nits (see below).

Thanks
-Andrea



================
Comment at: llvm/test/TableGen/CompressWriteLatencyEntry.td:1-3
+// RUN: llvm-tblgen -gen-subtarget -I %p/../../include %s 2>&1 | FileCheck %s
+// Check if this Write is not referenced by a ReadAdvance, don't distinguish it
+// from other WriteLatency entries.
----------------
Please insert an extra newline to better separate the RUN line from the other code code comment.

I also suggest to change that comment to something like this:
```
Make sure that ReadAdvance entries are correctly processed. Not all ProcReadAdvance definitions
implicitly inherit from SchedRead. Some ProcReadAdvances are subclasses of ReadAdvance.
```

Here, I have reused part of your original description from the summary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132205/new/

https://reviews.llvm.org/D132205