[PATCH] D133294: [Assignment Tracking][11/*] Update RemoveRedundantDbgInstrs

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 01:20:46 PDT 2022


Orlando updated this revision to Diff 460004.
Orlando marked 2 inline comments as done.
Orlando added a comment.

> I can sort of see why this is necessary (moving a variable from "linked" to "not linked" is a meaningful transition that we shouldn't remove), is there a definite use case for it, and is it covered by the test? (I don't see it being covered by the test, but I might not have read it correctly).

I've added `remove-redundant-fwd-scan-linked.ll` which is a test case reduced from real code. Note, this IR was generated using the (updated) DSE insert-undef behaviour in D133315 <https://reviews.llvm.org/D133315>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133294/new/

https://reviews.llvm.org/D133294

Files:
  llvm/lib/Transforms/Utils/BasicBlockUtils.cpp
  llvm/test/DebugInfo/Generic/assignment-tracking/remove-redundant-fwd-scan-linked.ll
  llvm/test/DebugInfo/Generic/assignment-tracking/remove-redundant.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133294.460004.patch
Type: text/x-patch
Size: 18506 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220914/b913f3f3/attachment.bin>


More information about the llvm-commits mailing list