[PATCH] D133253: [SPIRV] add IR regularization pass

[Aleksandr Bezzubikov via Phabricator via llvm-commits]

zuban32 added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp:1738
+static SPIRVType *getNonParametrizedType(const StructType *OpaqueType,
+                                         const SPIRV::DemangledType *TypeRecord,
+                                         MachineIRBuilder &MIRBuilder,
----------------
Pls remove tabs


================
Comment at: llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp:1747
+static SPIRVType *getSamplerType(MachineIRBuilder &MIRBuilder,
+                                 SPIRVGlobalRegistry *GR) {
   // Create or get an existing type from GlobalRegistry.
----------------
Tabs


================
Comment at: llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp:1784
+static SPIRVType *getSampledImageType(const StructType *OpaqueType,
+                                      MachineIRBuilder &MIRBuilder,
+                                      SPIRVGlobalRegistry *GR) {
----------------
Tabs


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133253/new/

https://reviews.llvm.org/D133253