[PATCH] D133422: [amdgpu] Expand all ConstantExpr users of LDS variables in instructions

Tue Sep 13 23:54:58 PDT 2022

JonChesterfield added a comment.

In D133422#3786748 <https://reviews.llvm.org/D133422#3786748>, @JonChesterfield wrote:

> In D133422#3785882 <https://reviews.llvm.org/D133422#3785882>, @foad wrote:
>
>>> Bug noted in D112717 <https://reviews.llvm.org/D112717> can be sidestepped with this change.
>>
>> Can you add a regression test for that bug?
>
> I could - would have to check the exact failure mode and write a fairly complicated test case

Test case was easier than anticipated - the constantexpr didn't have to be nested and block order doesn't make a difference. Added before commit. Fails the verifier before this patch, correct after.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133422/new/

https://reviews.llvm.org/D133422