[PATCH] D133690: [VP][RISCV] Add vp.sqrt intrinsic and RISC-V support.

Yeting Kuo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 19:36:06 PDT 2022


fakepaper56 marked 2 inline comments as done.
fakepaper56 added inline comments.


================
Comment at: llvm/docs/LangRef.rst:19219
+
+The '``llvm.vp.sqrt``' intrinsic performs floating-point square root value
+(:ref:`sqrt <int_sqrt>`) of the first vector operand on each enabled lane.  The
----------------
craig.topper wrote:
> Drop the word "value" here.
Done.


================
Comment at: llvm/docs/LangRef.rst:19221
+(:ref:`sqrt <int_sqrt>`) of the first vector operand on each enabled lane.  The
+result on disabled lanes is undefined.
+
----------------
craig.topper wrote:
> Need to add "The operation is performed in the default floating-point environment." to match other arithmetic instructions though."
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133690/new/

https://reviews.llvm.org/D133690



More information about the llvm-commits mailing list