[PATCH] D133625: [mlir][MemRef] Simplify extract_strided_metadata(expand_shape)

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet marked 3 inline comments as done.
qcolombet added inline comments.


================
Comment at: mlir/lib/Dialect/MemRef/Transforms/SimplifyExtractStridedMetadata.cpp:211
+    Value source = expandShape.getSrc();
+    auto sourceType = source.getType().cast<MemRefType>();
+    unsigned sourceRank = sourceType.getRank();
----------------
chelini wrote:
> 
I'm actually with you @chelini on that one, but following the LLVM coding standard, I think this is one of the mandatory auto. (I.e., clang-tidy, I think, would replace the type by auto here.)

More specifically this sentence "[...]Don’t “almost always” use auto, but do use auto with initializers like cast<Foo>(...)[...]" in the coding guide.
https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable

I'm happy to change it though.
Just let me know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133625/new/

https://reviews.llvm.org/D133625