[PATCH] D133537: [pipelines] RecomputeGlobalsAAPass after OptimizerEarlyEPCallbacks

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 16:55:17 PDT 2022


aeubanks added a comment.

In D133537#3787925 <https://reviews.llvm.org/D133537#3787925>, @vitalybuka wrote:

> Wouldn't be better to do so on PassBuilderPipelines like this, so we can cover any other future abandoning hooks?

We don't do that for all callbacks, I don't see why OptimizerEarlyEPCallbacks should be special. It's not typical to add passes that add globals. That's why it feels like it belongs wherever we add sanitizers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133537/new/

https://reviews.llvm.org/D133537



More information about the llvm-commits mailing list