[PATCH] D129727: [ARM64EC 11/?] Add support for lowering variadic indirect calls.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1467
+    setLibcallName(RTLIB::MEMSET, "#memset");
+    setLibcallName(RTLIB::MEMMOVE, "#memmove");
+  }
----------------
Is this actually necessary?  The linker should resolve plain "memcpy" to something reasonable, I think.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:6701
+  // FIXME: this should be a hack to make sure the HasVarSizedObjects=true,
+  // do we have better way here?
+  MachineFunction &MF = DAG.getMachineFunction();
----------------
In theory, you call CreateVariableSizedObject so that you can use the returned FrameIndex to refer to the object.  If you don't actually use the FrameIndex for anything, the call looks sort of silly, sure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129727/new/

https://reviews.llvm.org/D129727