[PATCH] D133153: [support] Prepare TimeProfiler for cross-thread support

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added a comment.
This revision is now accepted and ready to land.

In D133153#3787571 <https://reviews.llvm.org/D133153#3787571>, @mbs-modular wrote:

> Thanks @rriddle
>
>> Does the current diff contain all of the intended changes? All of the TimeProfiler changes look NFC.
>
> Yes, this is it, it's supposed to be NFC, and I can't explain @russell.gallop 's claimed regression.
> The only mostly-NFC change is I raised the stream type from raw_pwrite_stream to raw_ostream to help the unit tests (trivial as they are).

Can you revert that for now and just use raw_svector_ostream in the unittests? `raw_svector_ostream` implements `raw_pwrite_stream`, which should match the existing API. LGTM after that (though also wait if @russell.gallop has comments still).

@russell.gallop can you still repro a regression with the current patch?



================
Comment at: llvm/include/llvm/Support/TimeProfiler.h:80
 #include "llvm/ADT/STLFunctionalExtras.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/Error.h"
----------------
Why the extra include?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133153/new/

https://reviews.llvm.org/D133153