[PATCH] D133784: MachineFunction: Add verify method that accepts LiveIntervals

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 13:29:50 PDT 2022


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

Good idea. LGTM



================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:91-92
   struct MachineVerifier {
     MachineVerifier(Pass *pass, const char *b) : PASS(pass), Banner(b) {}
 
+    MachineVerifier(const char *b, LiveVariables *LiveVars,
----------------
Maybe just drop this constructor and the `PASS` member and instead add logic to `MachineVerifierPass::runOnMachineFunction` to query the analyses?

(as a suggestion, I don't mind too much if we don't do it in this diff).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133784/new/

https://reviews.llvm.org/D133784



More information about the llvm-commits mailing list