[PATCH] D131246: [AMDGPU] SIFixSGPRCopies refactoring

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 13:05:24 PDT 2022


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFixSGPRCopies.cpp:1108
+  if (T != PostProcessingLists.end()) {
+    T->second.List->erase(T->second.I);
+    PostProcessingLists.erase(MI);
----------------
Why not simply clean all of these lists/vectors/maps at the end of the runOnMachineFunction?


================
Comment at: llvm/lib/Target/AMDGPU/SIFixSGPRCopies.cpp:1112
+}
\ No newline at end of file

----------------
New line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131246/new/

https://reviews.llvm.org/D131246



More information about the llvm-commits mailing list