[PATCH] D133795: Don't populate the symbol table with symbols that don't belong to a section with the flag SHF_ALLOC

[Matheus Izvekov via Phabricator via llvm-commits]

mizvekov added inline comments.


================
Comment at: llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp:173
+    // allocated memory.
+    elf_section_iterator ESec(Sec.get());
+    if ((ESec->getFlags() & ELF::SHF_ALLOC) == 0) {
----------------
We generally prefer that, though it does seem unnecessary to declare that for a single use.
Might as well do: `if ((Sec.get()->getFlags() & ELF::SHF_ALLOC) == 0))`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133795/new/

https://reviews.llvm.org/D133795