[PATCH] D133795: Don't populate the symbol table with symbols that don't belong to a section with the flag SHF_ALLOC

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good - one minor change to drop braces from the `if`. (I can make this change myself if I'm submitting it for you)

Do you need me to submit this for you? (if you don't have LLVM commit access)



================
Comment at: llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp:174-176
+    if ((ESec->getFlags() & ELF::SHF_ALLOC) == 0) {
+      return Error::success();
+    }
----------------
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133795/new/

https://reviews.llvm.org/D133795