[PATCH] D133745: [ELF] Relocations: amends c8d9d0000b2f72b50729bfdc7bbb9dd3e9ecd6a0

Tue Sep 13 10:34:01 PDT 2022

adalava added a comment.

In D133745#3785544 <https://reviews.llvm.org/D133745#3785544>, @MaskRay wrote:

> I made a mistake in the commit message. It should be "if ifunc"... You can verify that `hasDirectReloc` (now `HAS_DIRECT_RELOC`) is only functional when `isGnuIfunc()` is true.

oh, np!

> I need a reproduce tarball to analyze. shared `STT_GNU_IFUNC` becomes `STT_FUNC` in Symbols.h:436 and an ifunc with `HAS_DIRECT_RELOC` is converted to `STT_FUNC`, too.
> The changes are necessary for correct semantics.

Here it is, with more details: https://github.com/llvm/llvm-project/issues/57722

Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133745/new/

https://reviews.llvm.org/D133745