[PATCH] D132221: [Assignment Tracking][2/*] Add flags to enable Assignment Tracking

Tue Sep 13 09:21:07 PDT 2022

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

In D132221#3777166 <https://reviews.llvm.org/D132221#3777166>, @Orlando wrote:

> In D132221#3758381 <https://reviews.llvm.org/D132221#3758381>, @jmorse wrote:
>
>> I get the feeling that this is creating two places to store the flag rather than one -- there's the `EnableAssignmentTracking` flag which ends up in TargetOptions I think(?), I believe   `MarshallingInfoFlag<CodeGenOpts<"EnableAssignmentTracking">>;` causes the Xclang flag to be stored there.
>
> I thought that it was putting it in `CodeGenOptions`, meaning we can check the value of the flag here in Clang - used in D132226 <https://reviews.llvm.org/D132226> (the `if` condition).

Uuuuuuuhhhh. Yeah you're right, that makes sense. Carry on. LGTM, wants the comment nit fixing though.

> I'm not trying to push back on any suggested changes, I am just slightly lost on this side of LLVM. It could well be that storing in `CodeGenOptions` is undesirable too, but I thought it was worth checking.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132221/new/

https://reviews.llvm.org/D132221