[PATCH] D133690: [VP][RISCV] Add vp.sqrt intrinsic and RISC-V support.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/docs/LangRef.rst:19219
+
+The '``llvm.vp.sqrt``' intrinsic performs floating-point square root value
+(:ref:`sqrt <int_sqrt>`) of the first vector operand on each enabled lane.  The
----------------
Drop the word "value" here.


================
Comment at: llvm/docs/LangRef.rst:19221
+(:ref:`sqrt <int_sqrt>`) of the first vector operand on each enabled lane.  The
+result on disabled lanes is undefined.
+
----------------
Need to add "The operation is performed in the default floating-point environment." to match other arithmetic instructions though."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133690/new/

https://reviews.llvm.org/D133690