[PATCH] D132441: Fix FindZ3.cmake's version detection mechanism

Evgeny Mandrikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 08:38:35 PDT 2022


Godin resigned from this revision.
Godin added a comment.

Sorry, but I'm not familiar with vcpkg

> why we can't always use the regex path as the final fallback plan

and I don't feel that I'm the right person to answer this question and take a decision about this, so have to resign from the reviewer here.

But to me personally this doesn't sound right, because if I understood you correctly it didn't result in link failure in this case, but might result in a runtime failure.

All other changes look good to me. So maybe will be better to leave them only and revert vcpkg-related changes here, especially since you also don't rely on it anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132441/new/

https://reviews.llvm.org/D132441



More information about the llvm-commits mailing list