[PATCH] D133730: [SimplifyCFG] Don't hoist allocas

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.

In D133730#3785909 <https://reviews.llvm.org/D133730#3785909>, @chill wrote:

> There's a comment about `mayHaveSideEffects` that's not entirely correct, maybe it can be reworded somewhat?
> https://github.com/llvm/llvm-project/blob/1f7b94e0ec7fae446e2ef9fcc41968fc711fb2c7/llvm/include/llvm/IR/Instruction.h#L630

The comment suggests isSafeToSpeculativelyExecute. Perhaps that is more appropriate for this transform, which hoists? Either way, correctness first, let's land the fix and you can iterate on improvements and simplifications.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133730/new/

https://reviews.llvm.org/D133730